Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126719: Clarify math.fmod documentation #127741

Merged
merged 5 commits into from
Jan 4, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Dec 8, 2024

This change was raised a month ago but has been forgotten about.

#126719


📚 Documentation preview 📚: https://cpython-previews--127741.org.readthedocs.build/

Doc/library/math.rst Outdated Show resolved Hide resolved
Doc/library/math.rst Outdated Show resolved Hide resolved
StanFromIreland and others added 2 commits December 8, 2024 17:07
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, that your diff looks much bigger, probably just due to formatting changes.

Please revert unrelated changes.

@StanFromIreland
Copy link
Contributor Author

formatting changes.

@skirpichev The formatting changes are necessary, how do I add them, the line is otherwise too long? Please advise.

@skirpichev
Copy link
Member

I don't think that patch from the issue has "too long" lines.

This may be rejected by lint as the line is too long.
Doc/library/math.rst Outdated Show resolved Hide resolved
Co-authored-by: Bénédikt Tran <[email protected]>
@picnixz picnixz requested a review from Eclips4 January 2, 2025 10:50
@erlend-aasland erlend-aasland changed the title gh-126719: Improve math.fmod documentation. gh-126719: Clarify math.fmod documentation Jan 4, 2025
@erlend-aasland erlend-aasland merged commit f28d471 into python:main Jan 4, 2025
29 checks passed
@erlend-aasland erlend-aasland added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 4, 2025
@miss-islington-app

This comment was marked as outdated.

@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
(cherry picked from commit f28d471)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
(cherry picked from commit f28d471)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 4, 2025

GH-128491 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 4, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 4, 2025

GH-128492 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 4, 2025
erlend-aasland pushed a commit that referenced this pull request Jan 4, 2025
(cherry picked from commit f28d471)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
erlend-aasland pushed a commit that referenced this pull request Jan 4, 2025
(cherry picked from commit f28d471)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@StanFromIreland StanFromIreland deleted the patch-2 branch January 4, 2025 18:34
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 6, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants